fixes bug 1058283 - Make a contribute.json endpoint #2313
Conversation
| "repository": { | ||
| "url": "https://github.com/mozilla/socorro", | ||
| "license": "MPL2", | ||
| "tests": "https://travis-ci.org/mozilla/socorro" |
There was a problem hiding this comment.
nit, but there are lots of whitespace problems that cause things at this level not to line up.
|
\o/ for adding the @peterbe |
|
r+ this lgtm - I do wonder why it's a separate file you're reading in, instead of using object notation directly in the view (and then doing json.dumps on that)? Is there an advantage to having |
Yes. Because then it's clearly visible right there when you load up github.com/mozilla/socorro. Just like the LICENSE or the README file. |
|
OK thanks for explanation :) |
| "postgresql", | ||
| "elasticsearch", | ||
| "rabbitmq", | ||
| "python" |
There was a problem hiding this comment.
By the time this file hits and becomes useful we might very well be away from hbase.
|
Does anybody know how to make a URL that lists all Socorro components? |
|
thanks @AdrianGaudebert I changed it. |
|
👍 |
| "elasticsearch", | ||
| "rabbitmq", | ||
| "python", | ||
| "css" |
peterbe
force-pushed
the
bug-1058283-make-a-contributejson-endpoint
branch
from
ab73e90
to
0678d80
Compare
|
Now rebased and squashed too. |
|
Last chance for any last minute feedback here. |
|
If anybody objects, we can change it later. |
…on-endpoint fixes bug 1058283 - Make a contribute.json endpoint
Dear ANYONE on the Socorro team,
please have a look at the new contribute.json file. If you see anything missing or incorrect please say.
The file validates which is a good start.