fixes bug 1148587 - 0x221 is the wrong adapter hex #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterbe r+! Thank you for fixing this. |
peterbe
pushed a commit
that referenced
this pull request
Mar 31, 2015
…adapter-hex fixes bug 1148587 - 0x221 is the wrong adapter hex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@selenamarie r? or if you're too busy getting started in your new team, @rhelmer r?
So, if you look at Adapter Graphics Report in the Signature Summary you'll see that all the hexes for the adapters we don't recognized are padded as 4 characters. E.g.
0x0221. And'0x0221' != '0x221'even thoughhex(int('0x0221', 16)) == hex(int('0x221', 16))is true.So that's why we miss so many adapters in the signature summary that starts with a leading 0. This PR fixes that.