Fixes bug 1207085 - Do not consider 0 as a falsy value in API.
#3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if param['required'] and not value and value != 0: | ||
| raise RequiredParameterError(name) | ||
|
|
||
| if not value and value != 0: | ||
| continue |
There was a problem hiding this comment.
So, if this continue happens, does that not mean the value isn't made available? Can't you just do:
if not value and value != 0:
if param['required']:
raise RequiredParameterError(name)
continueThere was a problem hiding this comment.
I can't put my finger on it but it feels strange that you're doing the ... != 0 check twice.
|
@AdrianGaudebert Note that the tests don't pass. |
|
Well, TIL: > False != 0
False
> False is not 0
True |
|
@peterbe comments addressed! |
|
Awesome! r+ |
adngdb
force-pushed
the
1207085-super-search-zero-false
branch
from
8cafc40
to
707c997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peterbe r?
I'm also upgrading
elasticsearch-dslto fix a bug: when you were querying for 0 results, it would instead return Elasticsearch's default number of results, which is 10. That's fixed with the latest version.