Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Bug1208129 - add proto_signature to processed crash #3005

Merged
merged 1 commit into from Sep 29, 2015
Merged

Fixes Bug1208129 - add proto_signature to processed crash #3005

merged 1 commit into from Sep 29, 2015

Conversation

twobraids
Copy link
Contributor

one of the eternal complaints about Socorro is the inability to search for crashes based on frames of the crashing thread's stack. While the signature is based on the frames of the crashing thread, it is heavily edited. The stack frames themselves are removed from the processed crash because of disk space issues.

During the process of creating a signature, there is a point when all the normalized frame signature are assembled into a list. This is just before the application of the skip list regular expressions. Taking this list of normalized frame signatures and concatenating them into one long string introduces a way to search the stack for patterns in calls.

Normally, after signature generation is complete, the list is thrown away. Rather than that, we should explore its usefulness as a search tool. I've dubbed this string the "proto_signature" and saved it under that name in the processed crash.

It isn't very useful for bucketing on its own, but an searchable exploratory tool it may be very useful.

@adngdb
Copy link
Contributor

adngdb commented Sep 25, 2015

r+

I'm going to add this field to our Super Search Fields list straight away so that it gets indexed correctly from the start.

twobraids added a commit that referenced this pull request Sep 29, 2015
Fixes Bug1208129 - add proto_signature to processed crash
@twobraids twobraids merged commit 07dc4c8 into mozilla-services:master Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants