Fixes Bug1208129 - add proto_signature to processed crash #3005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one of the eternal complaints about Socorro is the inability to search for crashes based on frames of the crashing thread's stack. While the signature is based on the frames of the crashing thread, it is heavily edited. The stack frames themselves are removed from the processed crash because of disk space issues.
During the process of creating a signature, there is a point when all the normalized frame signature are assembled into a list. This is just before the application of the skip list regular expressions. Taking this list of normalized frame signatures and concatenating them into one long string introduces a way to search the stack for patterns in calls.
Normally, after signature generation is complete, the list is thrown away. Rather than that, we should explore its usefulness as a search tool. I've dubbed this string the "proto_signature" and saved it under that name in the processed crash.
It isn't very useful for bucketing on its own, but an searchable exploratory tool it may be very useful.