Fixes bug 1225447 - Split query to graphics_devices into smaller chun… #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterbe So I had to do as you proposed and split the query, because the |
|
|
||
| adapters = [ | ||
| { | ||
| 'term': '0x{0:0>4}'.format(i), |
There was a problem hiding this comment.
what does this fancy thing do? :)
There was a problem hiding this comment.
It makes sure there are always 4 chars, and fills the string with zeros to the left if i is smaller than 4 chars. Do I really have to put a comment to explain that? It's part of the standard python library, not some deep logic that we built.
There was a problem hiding this comment.
No, I knew it was a format trick. I just didn't recognize it "by heart".
We only comment on business logic.
…ks to avoid hitting URL size limit. r=peterbe
adngdb
force-pushed
the
1225447-graphics-summary-split-query
branch
from
256962f
to
5581aa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ks to avoid hitting URL size limit.
@peterbe r?