Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug 1249805 - Added mozilla::CondVar::.* to the prefix list. #3212

Merged
merged 1 commit into from Feb 24, 2016

Conversation

adngdb
Copy link
Contributor

@adngdb adngdb commented Feb 22, 2016

cc @dbaron

@peterbe
Copy link
Contributor

peterbe commented Feb 24, 2016

This time you included the .* but you didn't in https://bugzilla.mozilla.org/attachment.cgi?id=8722017
David's bugs looked the same with regards to thoughts on the matter.

@adngdb
Copy link
Contributor Author

adngdb commented Feb 24, 2016

@peterbe yes, because this time I want to catch every function that starts with mozilla::CondVar::. So the regex is mozilla::CondVar::.*. In #3211 I just want to catch that precise function name, so there's no need for a regex.

@peterbe
Copy link
Contributor

peterbe commented Feb 24, 2016

🎉 Sounds like you've really thought about it and double-checked.

peterbe pushed a commit that referenced this pull request Feb 24, 2016
Fixes bug 1249805 - Added mozilla::CondVar::.* to the prefix list.
@peterbe peterbe merged commit dd878bc into mozilla-services:master Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants