Ensure throttle level is always set fixes bug 731325 #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please run check.py on all your Python files: there are a bunch of styling problems that it will raise. |
| @@ -84,3 +84,133 @@ How to configure your test environment | |||
| soccoro. E.g if you have installed socorro at | |||
| ``/home/tester/Mozilla/socorro`` then your PYTHONPATH should look like | |||
| ``...:/home/tester/Mozilla:/home/tester/Mozilla/thirdparty:...`` | |||
|
|
|||
| Writing a PostgreSQL middleware unit test | |||
There was a problem hiding this comment.
Actually, I think the "Writing a test" part should go into addaservice instead. Or at least there should be a link there to here, as it is really middleware-related.
|
@AdrianGaudebert changes made, please let me know if there is more or, if I missed something |
| from socorro.lib import datetimeutil | ||
| import socorro.unittest.testlib.util as testutil | ||
|
|
||
| from unittestbase import PostgreSQLTestCase |
There was a problem hiding this comment.
Please add a point before unittestbase so we know it comes from the same directory and is not a global Python module.
from .unittestbase import PostgreSQLTestCase
|
Code is good and tested, doc needs a bit of work before I r+. |
|
Latest documentation changes made and PR updated |
|
r+ Excellent work Schalk, thank you! |
adngdb
added a commit
that referenced
this pull request
Mar 27, 2012
…ong-731325 Ensure throttle level is always set fixes bug 731325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request also includes some documentation on writing and running unit tests.