AWS Profile #416
Merged
AWS Profile #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 11, 2019 14:40
* Decrypt * Command Line * Master Key
* Encrypt * .sops.yaml marshall
* Command Line argument fix
* Command Line argument fix for group add
* Decrypt * Command Line * Master Key * Encrypt * .sops.yaml
autrilla
reviewed
Jan 11, 2019
|
Great thanks, working through the comments now |
|
ok all updated :D |
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
- Coverage 43.38% 43.14% -0.24%
==========================================
Files 16 16
Lines 2206 2209 +3
==========================================
- Hits 957 953 -4
- Misses 1160 1166 +6
- Partials 89 90 +1
Continue to review full report at Codecov.
|
autrilla
approved these changes
Jan 14, 2019
|
Great thanks. Is there any idea when we can get a release so that we can get it automatically via homebrew? |
|
@marky-mark I got an email with a comment saying there was a small bug, has that been fixed? |
|
Not a bug, i forgot to add the profile to the encrypted file. All good |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #389
Added aws_profile
Tested locally, the tests pass except for 1...i think i'm missing an imported key