PageUp/PageDown not working

[basilesimon]

Hey guys,

I noticed that hitting PageUp/PageDown doesn't work - until clicking somewhere on the page. Both on Firefox and Chrome.

Can you replicate the issue?

If yes, I must admit I am not familiar with the code structure, would I be right to attack the problem in source/base/static/base/js?
I'd be happy to stick my nose into it.

[ryanpitts]

Hmm, that's an interesting one. Yep, I can replicate.

My guess is that this has to do with the snap.js library we use for the mobile slide-out menu (https://github.com/jakiestfu/Snap.js/). It works by setting the content frame to fixed position, and then actually doing the scrolling inside of that frame. (That way the menu can push it aside when it's called by the user.)

I'm only invoking the menu pane when the browser is narrow enough to need it (see: https://github.com/mozilla/source/blob/master/source/base/static/base/js/app.js#L72-L85), so I'll bet the CSS just needs to be adjusted so that the content pane isn't fixed unless it needs to be as well.

Thanks for pointing this out.

[basilesimon]

Hey @ryanpitts,

I had a look at the bug, but unfortunately I am very busy at the office these days, so I won't have the time to install the whole repo and run some tests.
As you appear to already know how to fix this issue, would you mind doing it? It would take too long for me to do it.

Cheers!

[ryanpitts]

Yep! It's on my list.