Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Redesign // UI-Design Edits #147

Closed
jess-cook03 opened this issue Jan 31, 2020 · 4 comments
Closed

Responsive Redesign // UI-Design Edits #147

jess-cook03 opened this issue Jan 31, 2020 · 4 comments

Comments

@jess-cook03
Copy link

jess-cook03 commented Jan 31, 2020

@kkellydesign

  • spacing, increase across all breakpoints, especially in header areas.

  • This 'Need more help' component. For now follow latest design as discussed -- ink-09 with metropolis -- instead of what is captured here below.
    Screen Shot 2020-01-30 at 1 02 20 PM

  • 'See All Products' link in the navigation, style like blue text link
    Screen Shot 2020-01-30 at 1 03 45 PM

  • Gravatar ?? lets try and round those corners and if you can figure out how to make the FxA avatar work instead then lets go with that (shown below)
    Screen Shot 2020-01-30 at 1 09 06 PM
    ![Img_avatar](https://user-images.githubusercontent.com/54991698/73578417-96b77f00-444d-11ea-887e-5def699b705a.png

  • Same with this on the profile editing, change this to upload/browse select your img or pencil icon on hover to edit photo ? Gravatar is weird hah.
    Screen Shot 2020-01-30 at 1 10 31 PM

  • Layouts with sidebar: sidebar sits on the right side, content sits to the left (needs to be switched in some pages ie. profile settings)
    Screen Shot 2020-01-30 at 1 13 01 PM

  • Make the checkboxes bigger - matching the UI specificed in system on Zeplin component library/protocol.
    Screen Shot 2020-01-30 at 1 12 06 PM

@jess-cook03 jess-cook03 added the bug Something isn't working label Jan 31, 2020
@jess-cook03 jess-cook03 added this to Triage in SUMO Engineering Board via automation Jan 31, 2020
@jess-cook03 jess-cook03 added this to the Responsive redesign milestone Jan 31, 2020
@jess-cook03 jess-cook03 moved this from Triage to Current Sprint in SUMO Engineering Board Jan 31, 2020
@kkellydesign
Copy link

@jess-cook03 This will be ready for another design pass when this is in:
mozilla/kitsune#4170

Screen Shot 2020-02-11 at 12 27 50 PM

form macros have been added to allow custom checkboxes anywhere, and maintain consistency. Whenever possible, use this new pattern for forms instead of {{ form.as_ul }}

Screen Shot 2020-02-11 at 11 40 03 AM

Screen Shot 2020-02-11 at 11 39 54 AM

Screen Shot 2020-02-11 at 10 53 00 AM

@jess-cook03
Copy link
Author

@kkellydesign marked for review considering a few elements here overlap with edits needed in other tickets -- ie Forum / thread pages #67 and need more help component edits #179

@kkellydesign
Copy link

@jess-cook03 If there is nothing left that is actionable in this ticket, I think it's good to be closed, even if there are related tickets open elsewhere. At this point, I think smaller single-topic tickets are best. Moving back to QA for confirmation.

@jess-cook03
Copy link
Author

Confirmed this is done

@jess-cook03 jess-cook03 removed bug Something isn't working ready for qa labels Mar 10, 2020
@jess-cook03 jess-cook03 moved this from QA to Ready to deploy in SUMO Engineering Board Mar 10, 2020
SUMO Engineering Board automation moved this from Ready to deploy to Done Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants