New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
browser version of sweet.js #24
Comments
Just tried running it through browserify but it died on trying to find a parse-js module. This is on windows, will try on osx later. |
Same happens on osx, unless escodegen is installed globally I think. Would probably be best if we could avoid using browserify though. |
If you make this run in the browser, I will make an AMD loader for it... :-) Just let me know when!
|
It should work in the browser with AMD now. |
You beautiful man. Thank you. I can't wait to make this sucker an AMD loader. :-D |
What do you think of the sweet object having a method to convert the AST back into the compiled JS. This would mean consumers of sweet.js on the client don't have to talk to escodegen directly. It's really more of a sweet.js dependency then a sweet.js consumers dependency... Example Problem: https://github.com/iammerrick/require-sweet/blob/master/src/sweeten.js#L4 Also, I think the dependencies Example Problem: https://github.com/iammerrick/require-sweet/blob/master/example/index.html#L12-14 I would be happy to make a pull request with these updates if you are open to it? |
Yeah, that all sounds great. |
Pull requested.! |
Awesome! |
Currently we have some node dependencies but would be nice to run in the browser. Need to factor out the
require
calls and do a little cleaning.The text was updated successfully, but these errors were encountered: