This repository has been archived by the owner on Mar 5, 2020. It is now read-only.
Link labels to form fields in add/change club modal. #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmmavis can you take a look at this? |
|
r+, @toolness could you please "rebase" :) |
Conflicts: pages/clubs.jsx
|
Ah, forsaken #688! Ok done :) |
toolness
added a commit
that referenced
this pull request
Apr 20, 2015
Link labels to form fields in add/change club modal.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with #722. Note that the "where are you located" field is not currently hooked up, because
react-selectdoesn't seem to support a11y at all, which is a big bummer.Also note that this adds an optional
idPrefixproperty to the modal component, which determines what the ultimateidfor each form field is. While this isn't strictly needed for these forms, since they're singleton modals, I thought it would be good to follow the convention of making them configurable by the parent component, sinceidattributes are in a global namespace and therefore parent components should be able to tweak them if needed.