Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove in_*_root_store columns from certificate table #69

Closed
jvehent opened this issue Dec 6, 2015 · 2 comments
Closed

Remove in_*_root_store columns from certificate table #69

jvehent opened this issue Dec 6, 2015 · 2 comments

Comments

@jvehent
Copy link
Contributor

jvehent commented Dec 6, 2015

Unless I'm mistaken, those columns are not used anymore, in favor of the trust table. Can we remove them from the schema entirely?

@0xdiba
Copy link
Contributor

0xdiba commented Dec 6, 2015

I can see in the code that it is currently used.
If we can get something out of them is another story though.

These fields are only used in root CA certs and their only use would be if we want an
easy and quick way to see the certificates that are currently in any given truststore.
If we don't have a use case for that I think they can go.

@jvehent
Copy link
Contributor Author

jvehent commented Dec 6, 2015

Haaa, now that makes sense. I misunderstood the meaning of the column, but it seems logical that it would indicate presence in the trust store.

@jvehent jvehent closed this as completed Dec 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants