Skip to content

Commit

Permalink
Fix up a bunch of things csslint complained about, removing duplicat …
Browse files Browse the repository at this point in the history
…properties and putting in some abstress LESS classes, changing 0px to 0, some other details
  • Loading branch information
ianb committed May 29, 2013
1 parent fc91e38 commit 9709c31
Show file tree
Hide file tree
Showing 4 changed files with 159 additions and 117 deletions.
25 changes: 25 additions & 0 deletions .csslint.rc
@@ -0,0 +1,25 @@
{
"empty-rules": false,
"empty-rules-reason": "LESS creates some empty rules",

"bulletproof-font-face": false,
"buttetproof-font-face-reason": "This only seems to apply when you provide multiple formats, and we aren't doing that",

"qualified-headings": false,
"qualified-headings-reason": "This happens as part of the reset, we reset headings inside .towtruck (though technically we aren't using headings so we could remove that reset)",

"adjoining-classes": false,
"adjoining-classes-reason": ".class1.class2 isn't supported in some older browsers, but we don't support those",

"vendor-prefix": false,
"vendor-prefix-reason": "We have some vendor prefixes in vendor-prefix-specific selectors, and CSSLint complains about that.",
"compatible-vendor-prefixes": false,
"compatible-vendor-prefixes-reason": "Same as vendor-prefix",

"duplicate-background-images": false,
"duplicate-background-images-reason": "LESS explodes out some background images, creating duplicates, but they aren't duplicated in the source.",

"fallback-colors": false,
"fallback-colors-reason": "Some old browsers don't support RGBA, but we don't care about those browsers"

}
12 changes: 11 additions & 1 deletion Gruntfile.js
Expand Up @@ -11,6 +11,12 @@ var vars = {

module.exports = function (grunt) {

var dumpLineNumbers = false;
if (!! grunt.option("less-line-numbers")) {
grunt.verbose.writeln("Enabling LESS line numbers");
dumpLineNumbers = true;
}

grunt.initConfig({
pkg: grunt.file.readJSON('package.json'),

Expand All @@ -19,6 +25,9 @@ module.exports = function (grunt) {
files: {
"build/towtruck/towtruck.css": "towtruck/towtruck.less",
"build/towtruck/recorder.css": "towtruck/recorder.less"
},
options: {
dumpLineNumbers: dumpLineNumbers
}
}
},
Expand Down Expand Up @@ -63,6 +72,7 @@ module.exports = function (grunt) {
csslint: {
// Check here for options: https://github.com/stubbornella/csslint/wiki/Rules
options: {
csslintrc: ".csslint.rc"
},
src: ["build/towtruck/towtruck.css"]
},
Expand Down Expand Up @@ -163,7 +173,7 @@ module.exports = function (grunt) {
}
grunt.log.writeln("writing " + src.cyan + " to " + dest.cyan);
grunt.file.write(dest, content);
};
}
return true;
}
);
Expand Down
1 change: 1 addition & 0 deletions towtruck/functions.less
Expand Up @@ -4,6 +4,7 @@
transition: @val;
-moz-transition: @val;
-webkit-transition: @val;
-o-transition: @val;
}

.transform-origin (...) {
Expand Down

0 comments on commit 9709c31

Please sign in to comment.