Deploy script fixes & cleanup #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 2, 2015 15:47
The directory of the currently running script is already on the path: https://docs.python.org/2/tutorial/modules.html#the-module-search-path ...so adding it is unnecessary. In addition, I don't believe we need the treeherder-service directory on the path, since we don't directly import anything from there.
The current fetch/reset/checkout doesn't correctly update the working directory when switching between branches. This new approach is recommended by: http://stackoverflow.com/a/9589927
We don't use git submodules, so let's not bother trying to update them.
Previously the revision file was regenerated after it had already been rsynced to the webheads, and as such the publicly accessible file displayed the previous revision, not the new revision.
The git reset already outputs the SHA/commit message for HEAD so most of this additional output is unnecessary.
Anything in the deploy script decorated with @task or @hostgroups ends up having it's progress displayed in IRC by the bot - eg: [2015-02-23 20:09:40] Finished deploy_log (0.454s) However, the "deploy_X" @hostgroup functions were actually only rsyncing the code (which is fast compared to restarting the processes), but the name used to imply the whole deploy for that node type was complete. The new structure not only reduces code duplication, but makes the IRC output more accurate, to provide a better idea as to what stage the deploy is at, and which are the problematic steps in the case of errors.
edmorley
pushed a commit
that referenced
this pull request
May 20, 2015
Update treeherder ui to use new optioncollectionhash API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes fixes for bug 1059814, bug 1135798, bug 1088705 & bug 1138392.
Please see the individual commit diffs and multi-line commit messages for easier review :-)