Merge pull request #209 from tojonmz/resultset-bar-improvements

Bug 1059279 - Improve resultset menu bar clarity and cancel access

webapp/app/css/treeherder.css

@@ -333,6 +333,11 @@ th-watched-repo {
     padding-left: 0;
 }
 
+/* Cancel all jobs custom icon size */
+.glyphicon-minus-sign {
+    font-size: 85%;
+}
+
 .revision-text {
     overflow: hidden;
     text-overflow: ellipsis;

webapp/app/partials/main/jobs.html

@@ -28,7 +28,15 @@
               ng-click="pinAllShownJobs()">
           <span class="glyphicon glyphicon-pushpin"></span>
         </span>
+
         <th-action-button ng-hide="isLoadingJobs"></th-action-button>
+
+        <span class="btn btn-default btn-sm"
+              tabindex="0" role="button"
+              title="cancel all jobs in this resultset"
+              ng-click="cancelAllJobs(resultset.revision)">
+          <span class="glyphicon glyphicon-minus-sign"></span>
+        </span>
       </span>
 
       <span class="btn btn-default btn-sm revision-button"

webapp/app/partials/main/thActionButton.html

@@ -1,12 +1,10 @@
     <span class="dropdown">
         <a class="btn btn-default btn-sm dropdown-toggle" data-hover="dropdown" data-delay="1000" href="#">
-            <i class="fa fa-external-link fa-lg"></i>
             <b class="caret"></b>
         </a>
         <ul class="dropdown-menu pull-left">
             <li><a target="_blank" href="https://tbpl.mozilla.org/mcmerge/?cset={{resultset.revision}}&tree={{repoName}}">mcMerge</a></li>
             <li><a target="_blank" href="https://secure.pub.build.mozilla.org/buildapi/self-serve/{{repoName}}/rev/{{resultset.revision}}">BuildAPI</a></li>
             <li><a target="_blank" href="" prevent-default-on-left-click  ng-click="openRevisionListWindow()">Revision URL List</a></li>
-            <li><a href="" prevent-default-on-left-click  ng-click="cancelAllJobs(resultset.revision)">Cancel All Jobs</a></li>
         </ul>
     </span>