This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Correct empty manual pin board bugs (1045774) #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camd
pushed a commit
that referenced
this pull request
Jul 31, 2014
Correct empty manual pin board bugs (1045774)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work fixes Bugzilla bug 1045774 and replicates previous PR110.
As described in the bug, when creating bugs sequentially by clicking the little "+" icon on the pin board and manually typing/pasting their values - the 2nd-to-N-th bugs after hitting enter, all have empty UI. It appears that
newEnteredBugNumberwas being set tonullafter its first pass (which perhaps explains why the 1st attempt worked).Here is the appearance before and after the fix, using two bug numbers, "123" and "456":
Looking at the repo, it appears the fix is limited to just this file. But as a newbie I don't know if I am missing anything else in the implications of the change. I have tested the UI pretty extensively with the change, manual bug entry, pasted bug entry, regular bug pinning, removals, illegal characters, etc.
@camd asked on IRC if the input field caches the last entered bug number, and it does (whether or not that is desired). But that behavior is true in the repo and on dev/stage/prod, and that behavior is independent of this fix.
Tested on Windows:
FF Release 31.0
Chrome Latest Release 36.0.1985.125 m
Adding @jeads and @camd for visibility.