initial work to get compare-talos stood up inside of perfherder #465
Conversation
|
Thank you for taking a look at this :-) |
|
|
||
| <script src="js/config/local.conf.js"></script> | ||
|
|
||
| <!-- build:js js/perf.min.js --> |
There was a problem hiding this comment.
This will override the perf.js file. Let's change perf.min.js -> compare.min.js. As @edmorley pointed out, you'll also need to make some gruntfile changes for the minification to work in production.
|
If there was an online version where the progress could be tested (rather than only after you declare it done), it could help others give feedback. |
|
avih you can clone my repo and run it locally- it is very easy! I don't think wlach is going for perfection here, just basics to get it in and we can iterate on it. |
|
@avih, install nodejs then just: |
|
Maybe it will and maybe it won't work out of the box (and it'd also need figuring out how to operate it, where to point various bits, etc), but a link to a live preview of a specific changeset with the thing which you want feedback for right at the front - would help a lot for people who don't work on this regularly. |
|
Is there a staging server where these changesets could be deployed and examined in a relatively quick cycle? |
|
Avi. This is a pull request. It needs some type of sanity review before Joel
|
|
@jmaher, you could also clone the branch into a people.m.o account (and cp the example config file, which points at prod's API) if you wanted feedback before merging - it should Just Work from there too. |
| @@ -0,0 +1,40 @@ | |||
| <!DOCTYPE html> | |||
… colspan=2, support url param hideMinorChanges
| <html ng-app="compare"> | ||
| <head> | ||
| <meta charset="iso-8859-1" /> | ||
| <title>Compare Talos</title> |
There was a problem hiding this comment.
Let's call this Compare Performance as we'll be using this for things aside from Talos at some point likely in the not too distant future.
…areperf.js/, cleaned up angular classes and extra <div>'s, reduced a forEach(..) call to a _.where(...) call, etc.
…yle, and combining verifyRevision bits
… colspan=2, support url param hideMinorChanges
…areperf.js/, cleaned up angular classes and extra <div>'s, reduced a forEach(..) call to a _.where(...) call, etc.
|
Merged manually. |
first round attempt.