This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Bug 1142680 - perfherder compare subtest view #485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,19 @@ | |||
|
|
|||
| var perf = angular.module("perf", ['ui.router', 'ui.bootstrap', 'treeherder']); | |||
|
|
|||
| perf.factory('isReverseTest', [ function() { | |||
There was a problem hiding this comment.
We should really be picking this up in the signature. Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1158233 for this
| var options = [ optionCollectionMap[signatureProps.option_collection_hash] ]; | ||
| if (e10s) { | ||
| options.push("e10s"); | ||
| perf.factory('phSeries', ['$http', 'thServiceDomain', function($http, thServiceDomain) { |
There was a problem hiding this comment.
For whatever reason, the convention seems to be to capitalize factories. I.e. phSeries should be PhSeries.
|
thanks for the awesome feedback, I have updated the commit with --amend and all items should be addressed. This feels a lot cleaner now- not perfect, but many workable! |
| }]); | ||
|
|
||
|
|
||
| perf.factory('getResultsMap', [ '$q', '$http', 'thServiceDomain', 'phSeries', 'math', |
There was a problem hiding this comment.
Let's fold getCounterMap, getResultsMap into a factory called PhCompare -- they're only really useful in that context.
|
updated PR with --amend, this should be rad! |
|
Merged manually. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial work with some refactoring to get subtests viewed from the compare view on perfherder.