This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Bug 1142680 - Write a compare-talos equivalent - optimizations and bar graphs. r=wlach #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: webapp/app/js/compareperf.js webapp/app/partials/perf/comparesubtestctrl.html
…r graphs. r=wlach
| timeRange = Math.round(now - timeRange); | ||
|
|
||
| //now figure out which predefined set of data we can query from | ||
| var intervals = [86400, 604800, 1209600, 2592000, 5184000, 7776000]; |
There was a problem hiding this comment.
So this is already used here: https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/js/graphs.js#L16
We should create an angular value for this so we can reuse this information here, there, and elsewhere. The keys should be the human readable name, the value the integer values we send to treeherder/perfherder (for cases we just need the values, just get the values). Some examples here: https://github.com/jmaher/treeherder-ui/blob/subtest/webapp/app/js/values.js
…r graphs. r=wlach
|
we can close this PR as #491 is used with a real branch, etc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimizations for:
tested with:
http://localhost:8000/app/perf.html#/compare?originalProject=try&originalRevision=76b999af7321&newProject=try&newRevision=59b75c0e8e97
optimizations: