This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Enable text copy from log steps buttons (1030627) #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camd
pushed a commit
that referenced
this pull request
Jul 9, 2014
Enable text copy from log steps buttons (1030627) Looks great! I think the Chrome issue is pretty minor. And doesn't everybody just use Firefox all the time anyway? :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work addresses Bugzilla bug 1030627.
The log steps and the log step error lines can now be selected, copied and pasted, like TBPL. I've tested a variety of failed jobs using different log content of varying sizes (short, hugely long) and it seems to behave as expected on Firefox.
As noted in the bug, it works fine on Google Chrome, but the carriage-returns get lost during the copy. I have been digging on stack overflow, and trying some workarounds injecting discrete line endings, but Chrome seems to ignore them too. There seems to be a number of complaints about Chrome with this behavior in both directions, including this example.
There were a few white space corrections made in the files, in proximity to changed code.
Adding @jeads for visibility.
Tested on Windows:
FF Release 30.0
Chrome Latest Release 35.0.1916.153 m