This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Add revision link to logviewer (1032504) #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camd
pushed a commit
that referenced
this pull request
Jul 15, 2014
Add revision link to logviewer (1032504)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work addresses item 2 of Bugzilla bug 1032504.
It would be really handy if the log viewer, linked to its resultset on treeherder.I have split the main bug above into separate PR's to speed up delivery. And to make things easier to revert anything, in the (hopefully unlikely) event that was necessary.
The revision now appears as a suitable link in logviewer, and handles revisions of varying sizes. I've tested a variety of logs from failed jobs from different repos and it appears to behave correctly on both Firefox and Chrome.
During the work, I thought I might have required other logviewer controller parameters. That turned out not to be the case. However during that period, I agreed with @camd on IRC that a sorted alphabetic list for main elements followed by alphabetic Th elements made sense. Similarly mimicking the same ordering for the .js modules in logviewer.html (which is already sort-of in place in index.html) as alphabetic and divided by category. So even though no additions ended up being needed, I left that re-ordering in. There was also some minor white space cleanup.
If I get time I will do that alphabetic re-ordering across all files, later, in separate work. It seemed to make it a bit easier for me to compare files.
Tested on Windows:
FF Release 30.0
Chrome Latest Release 35.0.1916.153 m