Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GhA task to run the probe-scraper workflow #7618

Merged
merged 1 commit into from Jan 10, 2023

Conversation

badboy
Copy link
Member

@badboy badboy commented Jan 6, 2023

This ensures:

  • On pull-requests probe-scraper can verify that Glean metrics are declared correctly.
  • On pushes to the default branch probe-scraper is informed to generate metrics data in the pipeline, to fill the Glean Dictionary and populate the table schemas.

This is part of Step 4 of adding Glean to your product. See also mozilla/probe-scraper#538 for enabling it in probe-scraper to begin with.
This requires enabling GitHub actions on this repository. Someone with write/admin access probably needs to do that.

This ensures:

* On pull-requests probe-scraper can verify that Glean metrics are
  declared correctly.
* On pushes to the default branch probe-scraper is informed to generate
  metrics data in the pipeline, to fill the Glean Dictionary and
  populate the table schemas.
@badboy
Copy link
Member Author

badboy commented Jan 6, 2023

Ah, fun fact: it ran in my fork (and failed, I'll merge the other PR and then gha here should pass): https://github.com/badboy/treeherder/actions/runs/3854229773/jobs/6567989655

@codecov-commenter
Copy link

Codecov Report

Base: 90.69% // Head: 90.69% // No change to project coverage 👍

Coverage data is based on head (ab49563) compared to base (9f1cf0d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7618   +/-   ##
=======================================
  Coverage   90.69%   90.69%           
=======================================
  Files         296      296           
  Lines       15134    15134           
=======================================
  Hits        13726    13726           
  Misses       1408     1408           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@badboy
Copy link
Member Author

badboy commented Jan 10, 2023

cc @jmaher this will be required for new data to be available

Copy link
Collaborator

@jmaher jmaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will deploy and figure out how to get github actions to work with this.

@jmaher jmaher merged commit 903447c into mozilla:master Jan 10, 2023
@badboy badboy deleted the probe-scraper-push branch January 12, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants