Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 2.6 support #25

Merged
merged 2 commits into from Nov 3, 2017
Merged

Conversation

nitely
Copy link
Contributor

@nitely nitely commented Mar 30, 2017

Fixes #24

unidecode package no longer supports python 2.6.

A side effect of this is being able to do io.open('README.md', encoding='utf-8').read() in the setup.py file

@hugovk
Copy link

hugovk commented Oct 18, 2017

pip install from PyPI for last month show virtually nothing from 2.6:

$ pypinfo --percent --pip unicode-slugify pyversion
python_version percent download_count
-------------- ------- --------------
2.7              60.2%         11,086
3.5              13.9%          2,557
3.6              13.0%          2,404
3.4              12.8%          2,367
2.6               0.0%              9
3.7               0.0%              6
3.3               0.0%              1

How about also dropping 3.3? It's been EOL since last month.

@davedash
Copy link
Contributor

davedash commented Nov 2, 2017

@nitely can you bump the minor version for this?

@nitely
Copy link
Contributor Author

nitely commented Nov 3, 2017

@davedash done 👌

@nitely
Copy link
Contributor Author

nitely commented Nov 3, 2017

@davedash btw PR #22 won't fix the issue for Python 2.7. I can implement the io.open('README.md', encoding='utf-8').read() solution if you want me to, or you can do it later.

@davedash
Copy link
Contributor

davedash commented Nov 3, 2017

@nitely if you have the time, please do.

@davedash davedash merged commit c3b1f4d into mozilla:master Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants