Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify check_library_path semantics #2095

Closed
mhammond opened this issue May 6, 2024 · 2 comments
Closed

Clarify check_library_path semantics #2095

mhammond opened this issue May 6, 2024 · 2 comments

Comments

@mhammond
Copy link
Member

mhammond commented May 6, 2024

This library mode check is unclear. Every language has an identical check, except Swift which is a noop.

It looks like it's really just checking in a round-about way that library_mode::calc_cdylib_name didn't return None - but why trait and that fact Swift is the only thing that does not check? And in my local test, Swift doesn't fail if you do. I got a bit lost in blame, so @bendk do you have recollections about this?

@bendk
Copy link
Contributor

bendk commented May 6, 2024

Yeah, that's definitely unclear. My half memory / half guess is that Swift doesn't need the check because it can work with static linking.

@mhammond
Copy link
Member Author

This was answered in #2094 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants