Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link "pt-BR" localization to "pt" #1962

Closed
nukeador opened this issue Apr 24, 2019 · 12 comments
Closed

Link "pt-BR" localization to "pt" #1962

nukeador opened this issue Apr 24, 2019 · 12 comments

Comments

@nukeador
Copy link
Contributor

Hi,

Dataset languages include Portuguese "pt" without any variants but currently we just have pt-BR localization.

As a temporal way to fix Portuguese dataset collection, I would like to request we use pt-BR localization for pt and enable it on the site, this way we will be able to add sentences.

pt-BR should redirect to pt on the site.

Cheers.

@kdavis-mozilla
Copy link
Contributor

pt-BR and pt are spoken quite differently and written somewhat differently.

@nukeador
Copy link
Contributor Author

Let's have a conversation about this before closing the issue, thanks.

@kdavis-mozilla
Copy link
Contributor

Oh sorry, didn't mean to close this.

@nukeador
Copy link
Contributor Author

Based on the conversations we had about language strategy, let's move ahead to avoid blocking Portuguese anymore.

@Gregoor can we mirror for now "pt-BR" into "pt" and enable the site just in "pt"?

@Gregoor
Copy link
Contributor

Gregoor commented Jul 18, 2019

@nukeador we can, haven't renamed a locale before, wanna make sure I get the process right. Let's put it onto the todos for next week! (Don't think it'll take long, it's just a first)

@peiying2
Copy link
Collaborator

peiying2 commented Jul 18, 2019

@Gregoor @nukeador I am working on something similar for other projects: consolidating two bn-* locales to bn. This is what we are doing so we don't lose the data in Pontoon:

Gregor:

  • create a pt repo
  • move pt-BR repo to pt
  • remove pt-BR repo (let us know when this is done)

Pontoon:

  • disable pt-BR (to stop contributing to the locale)
  • migrate pt-BR data to pt (including contributor's history)
  • L10n PM confirms the update and comment in the issue, so we can close the task.

@nukeador
Copy link
Contributor Author

nukeador commented Jul 29, 2019

@peiying2 can you clarify what do you mean by "repo" here?

My understanding is that we should move/rename folders.

Peiying's feedback:

https://github.com/mozilla/voice-web/tree/master/web/locales - I would recommend to make a copy of pt-BR and rename it to pt.

This will allow you to go to all the files containing locale related information and make the necessary changes before removing pt-BR web files.

Make sure this is done in a timely manner if you don't have two locales co-existing for a period of time, but completely switch over. Here are some example of the places you need to make update:

https://github.com/mozilla/voice-web/blob/master/locales/native-names.json
https://github.com/mozilla/voice-web/blob/master/locales/translated.json

@nukeador
Copy link
Contributor Author

@Gregoor please review all proposed changes

#2132

@peiying2
Copy link
Collaborator

While you are at it, pls remove bn-BD locale too, since you already have bn there.

@nukeador
Copy link
Contributor Author

nukeador commented Aug 2, 2019

@peiying2 pt-BT → pt folder change has been committed to master

@nukeador
Copy link
Contributor Author

nukeador commented Aug 5, 2019

Changes are now on production

https://voice.mozilla.org/pt

@Gregoor We might want to redirect the old /pt-BR/ url to the new /pt/ one

@Gregoor
Copy link
Contributor

Gregoor commented Aug 6, 2019

Oh yeah, good idea! Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants