-
Notifications
You must be signed in to change notification settings - Fork 332
/
test.program.js
409 lines (368 loc) · 12.5 KB
/
test.program.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
/* @flow */
import path from 'path';
import {describe, it} from 'mocha';
import git from 'git-rev-sync';
import {fs} from 'mz';
import sinon, {spy} from 'sinon';
import {assert} from 'chai';
import {defaultVersionGetter, main, Program} from '../../src/program';
import commands from '../../src/cmd';
import {onlyInstancesOf, UsageError} from '../../src/errors';
import {fake, makeSureItFails} from './helpers';
import {ConsoleStream} from '../../src/util/logger';
describe('program.Program', () => {
function execProgram(program, options = {}) {
const fakeProcess = fake(process);
const absolutePackageDir = path.join(__dirname, '..', '..');
return program.execute(
absolutePackageDir, {
getVersion: () => spy(),
checkForUpdates: spy(),
systemProcess: fakeProcess,
shouldExitProgram: false,
...options,
});
}
it('executes a command callback', () => {
const thing = spy(() => Promise.resolve());
const program = new Program(['thing'])
.command('thing', 'does a thing', thing);
return execProgram(program)
.then(() => {
assert.equal(thing.called, true);
});
});
it('reports unknown commands', () => {
const program = new Program(['thing']);
return execProgram(program)
.then(makeSureItFails())
.catch(onlyInstancesOf(UsageError, (error) => {
assert.match(error.message, /Unknown command: thing/);
}));
});
it('reports missing command', () => {
const program = new Program([]);
return execProgram(program)
.then(makeSureItFails())
.catch(onlyInstancesOf(UsageError, (error) => {
assert.match(error.message, /No sub-command was specified/);
}));
});
it('exits 1 on a thrown error', () => {
const fakeProcess = fake(process);
const program = new Program(['cmd'])
.command('cmd', 'some command', () => {
throw new Error('this is an error from a command handler');
});
return execProgram(program, {
systemProcess: fakeProcess,
shouldExitProgram: true,
})
.then(() => {
assert.equal(fakeProcess.exit.called, true);
assert.equal(fakeProcess.exit.firstCall.args[0], 1);
});
});
it('throws an error if sub-command is given an argument', () => {
const program = new Program(['thing', 'nope'])
.command('thing', '', () => {});
return execProgram(program)
.then(makeSureItFails())
.catch((error) => {
assert.match(error.message, /This command does not take any arguments/);
});
});
it('handles errors that have codes', () => {
class ErrorWithCode extends Error {
code: string;
constructor() {
super('pretend this is a system error');
this.code = 'SOME_CODE';
}
}
const program = new Program(['cmd'])
.command('cmd', 'some command', () => {
const error = new ErrorWithCode();
throw error;
});
// This is just a smoke test to make sure the error code doesn't
// introduce an unexpected exception.
return execProgram(program)
.then(makeSureItFails())
.catch((error) => {
assert.match(error.message, /pretend this is a system error/);
});
});
it('lets commands define options', () => {
const handler = spy(() => Promise.resolve());
const program = new Program(['cmd'])
.command('cmd', 'some command', handler, {
'some-option': {
default: 'default value',
},
});
return execProgram(program)
.then(() => {
assert.equal(handler.called, true);
// This ensures that the default configuration for the option has
// been applied.
assert.equal(handler.firstCall.args[0].someOption, 'default value');
});
});
it('preserves global option configuration', () => {
const handler = spy(() => Promise.resolve());
const program = new Program(['cmd'])
.setGlobalOptions({
'global-option': {
type: 'string',
default: 'the default',
},
})
.command('cmd', 'some command', handler, {
'some-option': {
default: 'default value',
},
});
return execProgram(program)
.then(() => {
assert.equal(handler.called, true);
// By checking the global default, it ensures that default configuration
// will be applied to sub commands.
assert.equal(handler.firstCall.args[0].globalOption, 'the default');
assert.equal(handler.firstCall.args[0].someOption, 'default value');
});
});
it('reads option values from env vars in sub commands', () => {
// Set an env var that mimics web-ext cmd --some-opt=value
process.env.WEB_EXT_SOME_OPT = 'value';
let valueReceived;
const program = new Program(['cmd'])
.command('cmd', 'some command', ({someOpt}) => {
valueReceived = someOpt;
}, {
'some-opt': {
describe: 'example option',
},
});
return execProgram(program, {shouldExitProgram: true})
.then(() => {
assert.equal(valueReceived, 'value');
delete process.env.WEB_EXT_SOME_OPT;
});
});
it('configures the logger when verbose', () => {
const logStream = fake(new ConsoleStream());
const program = new Program(['--verbose', 'thing']);
program.setGlobalOptions({
verbose: {
type: 'boolean',
},
});
program.command('thing', 'does a thing', () => {});
return execProgram(program, {
getVersion: spy(),
logStream,
})
.then(() => {
assert.equal(logStream.makeVerbose.called, true);
});
});
it('checks the version when verbose', () => {
const version = spy();
const program = new Program(['--verbose', 'thing']);
program.setGlobalOptions({
verbose: {
type: 'boolean',
},
});
program.command('thing', 'does a thing', () => {});
return execProgram(program, {getVersion: version})
.then(() => {
assert.equal(version.firstCall.args[0],
path.join(__dirname, '..', '..'));
});
});
it('does not configure the logger unless verbose', () => {
const logStream = fake(new ConsoleStream());
const program = new Program(['thing']).command('thing', '', () => {});
program.setGlobalOptions({
verbose: {
type: 'boolean',
},
});
return execProgram(program, {logStream})
.then(() => {
assert.equal(logStream.makeVerbose.called, false);
});
});
it('throws an error about unknown commands', () => {
return execProgram(new Program(['nope']))
.then(makeSureItFails())
.catch((error) => {
assert.match(error.message, /Unknown command: nope/);
});
});
it('throws an error about unknown options', () => {
return execProgram(new Program(['--nope']))
.then(makeSureItFails())
.catch((error) => {
// It's a bit weird that yargs calls this an argument rather
// than an option but, hey, it's an error.
assert.match(error.message, /Unknown argument: nope/);
});
});
it('throws an error about unknown sub-command options', () => {
const program = new Program(['thing', '--nope'])
.command('thing', '', () => {});
return execProgram(program)
.then(makeSureItFails())
.catch((error) => {
// Again, yargs calls this an argument not an option for some reason.
assert.match(error.message, /Unknown argument: nope/);
});
});
it('checks for updates automatically', () => {
const handler = spy();
const getVersion = () => 'some-package-version';
const checkForUpdates = sinon.stub();
const program = new Program(['run'])
.command('run', 'some command', handler);
return execProgram(program, {
checkForUpdates,
getVersion,
globalEnv: 'production',
})
.then(() => {
assert.equal(checkForUpdates.firstCall.args[0].version,
'some-package-version');
});
});
it('does not check for updates during development', () => {
const handler = spy();
const getVersion = () => 'some-package-version';
const checkForUpdates = sinon.stub();
const program = new Program(['run'])
.command('run', 'some command', handler);
return execProgram(program, {
checkForUpdates,
getVersion,
globalEnv: 'development',
})
.then(() => {
assert.equal(checkForUpdates.called, false);
});
});
});
describe('program.main', () => {
function execProgram(argv, {projectRoot = '', ...mainOptions}: Object = {}) {
const runOptions = {
getVersion: () => 'not-a-real-version',
checkForUpdates: spy(),
shouldExitProgram: false,
systemProcess: fake(process),
};
return main(projectRoot, {argv, runOptions, ...mainOptions});
}
it('executes a command handler', () => {
const fakeCommands = fake(commands, {
build: () => Promise.resolve(),
});
return execProgram(['build'], {commands: fakeCommands})
.then(() => {
// This is a smoke test mainly to make sure main() configures
// options with handlers. It does not extensively test the
// configuration of all handlers.
assert.equal(fakeCommands.build.called, true);
});
});
it('can get the program version', () => {
const fakeVersionGetter = sinon.spy(() => '<version>');
const fakeCommands = fake(commands, {
build: () => Promise.resolve(),
});
const projectRoot = '/pretend/project/root';
// For some reason, executing --version like this
// requires a command. In the real CLI, it does not.
return execProgram(['--version', 'build'],
{
projectRoot,
commands: fakeCommands,
getVersion: fakeVersionGetter,
})
.then(() => {
assert.equal(fakeVersionGetter.called, true);
assert.equal(fakeVersionGetter.firstCall.args[0], projectRoot);
});
});
it('turns sourceDir into an absolute path', () => {
const fakeCommands = fake(commands, {
build: () => Promise.resolve(),
});
return execProgram(
['build', '--source-dir', '..'], {commands: fakeCommands})
.then(() => {
assert.equal(fakeCommands.build.called, true);
assert.equal(fakeCommands.build.firstCall.args[0].sourceDir,
path.resolve(path.join(process.cwd(), '..')));
});
});
it('normalizes the artifactsDir path', () => {
const fakeCommands = fake(commands, {
build: () => Promise.resolve(),
});
return execProgram(
// Add a double slash to the path, which will be fixed by normalization.
['build', '--artifacts-dir', process.cwd() + path.sep + path.sep],
{commands: fakeCommands})
.then(() => {
assert.equal(fakeCommands.build.called, true);
assert.equal(fakeCommands.build.firstCall.args[0].artifactsDir,
process.cwd() + path.sep);
});
});
it('passes the path of a firefox binary when specified', () => {
const fakeCommands = fake(commands, {
run: () => Promise.resolve(),
});
return execProgram(
['run', '--firefox-binary', '/path/to/firefox-binary'],
{commands: fakeCommands})
.then(() => {
assert.equal(fakeCommands.run.called, true);
assert.equal(fakeCommands.run.firstCall.args[0].firefox,
'/path/to/firefox-binary');
});
});
it('converts custom preferences into an object', () => {
const fakeCommands = fake(commands, {
run: () => Promise.resolve(),
});
return execProgram(
['run', '--pref', 'prop=true', '--pref', 'prop2=value2'],
{commands: fakeCommands})
.then(() => {
const {customPrefs} = fakeCommands.run.firstCall.args[0];
assert.isObject(customPrefs);
assert.equal(customPrefs.prop, true);
assert.equal(customPrefs.prop2, 'value2');
});
});
});
describe('program.defaultVersionGetter', () => {
const root = path.join(__dirname, '..', '..');
it('returns the package version in production', () => {
const pkgFile = path.join(root, 'package.json');
return fs.readFile(pkgFile)
.then((pkgData) => {
const testBuildEnv = {globalEnv: 'production'};
assert.equal(defaultVersionGetter(root, testBuildEnv),
JSON.parse(pkgData).version);
});
});
it('returns git commit information in development', () => {
const commit = `${git.branch()}-${git.long()}`;
const testBuildEnv = {globalEnv: 'development'};
assert.equal(defaultVersionGetter(root, testBuildEnv),
commit);
});
});