feat: Added --timeout option for signing

mozilla · Apr 30, 2016 · 2c176b2 · 2c176b2
1 parent 982d5c5
commit 2c176b2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/src/cmd/sign.js b/src/cmd/sign.js
@@ -12,7 +12,7 @@ const log = createLogger(__filename);
 
 export default function sign(
     {verbose, sourceDir, artifactsDir, apiKey, apiSecret,
-     apiUrlPrefix}: Object,
+     apiUrlPrefix, timeout}: Object,
     {build=defaultBuilder, signAddon=defaultAddonSigner,
      preValidatedManifest=null}: Object = {}): Promise {
 
@@ -38,6 +38,7 @@ export default function sign(
           apiKey,
           apiSecret,
           apiUrlPrefix,
+          timeout,
           verbose,
           xpiPath: buildResult.extensionPath,
           id: manifestData.applications.gecko.id,

diff --git a/src/program.js b/src/program.js
@@ -167,6 +167,10 @@ Example: $0 --help run.
         demand: true,
         type: 'string',
       },
+      'timeout' : {
+        describe: 'Number of milleseconds to wait before giving up',
+        type: 'number',
+      },
     })
     .command('run', 'Run the web extension', commands.run, {
       'firefox-binary': {

diff --git a/tests/test-cmd/test.sign.js b/tests/test-cmd/test.sign.js
@@ -17,6 +17,7 @@ describe('sign', () => {
       apiKey: 'AMO JWT issuer',
       apiSecret: 'AMO JWT secret',
       apiUrlPrefix: 'http://not-the-real-amo.com/api/v3',
+      timeout: 999,
     };
 
     const buildResult = {
@@ -102,6 +103,8 @@ describe('sign', () => {
                        stubs.signingConfig.apiSecret);
           assert.equal(signedAddonCall.apiUrlPrefix,
                        stubs.signingConfig.apiUrlPrefix);
+          assert.equal(signedAddonCall.timeout,
+                       stubs.signingConfig.timeout);
           assert.equal(signedAddonCall.xpiPath,
                        stubs.buildResult.extensionPath);
           assert.equal(signedAddonCall.id,