Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-input option to disable standard input #1030

Closed
kumar303 opened this issue Aug 4, 2017 · 7 comments
Closed

Add --no-input option to disable standard input #1030

kumar303 opened this issue Aug 4, 2017 · 7 comments

Comments

@kumar303
Copy link
Contributor

kumar303 commented Aug 4, 2017

Is this a feature request or a bug?

feature

What is the current behavior?

web-ext run will allow you to press keys (such as R) to trigger a reload.

What is the expected or desired behavior?

It should be possible to disable this if desired with something like web-ext run --no-input.

Adding this as a global option should be really easy because the noInput parameter was already added in #1028

@serendicoder
Copy link
Contributor

Hi @kumar303 ,
May I work on this?

@kumar303
Copy link
Contributor Author

kumar303 commented Aug 5, 2017

@serendicoder Yes. Thank you!

@jvillalobos
Copy link

Mentor: @kumar303 :)

@serendicoder
Copy link
Contributor

Hi @kumar303 ,
I am ready with the dev environment, created a simple addon with web-ext and going through the docs.
As a first step, I am adding no-input option to setGlobalOptions. How do I go ahead from here, please suggest. Thanks!

@kumar303
Copy link
Contributor Author

kumar303 commented Aug 9, 2017

Sounds like you're on the right track. You can create a pull request and I'll take a look.

@serendicoder
Copy link
Contributor

Hi @kumar303 , please take a look and suggest further steps.

@kumar303
Copy link
Contributor Author

kumar303 commented Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants