Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Normalize default_locale before use #1637

Merged
merged 1 commit into from
Jun 25, 2019
Merged

fix: Normalize default_locale before use #1637

merged 1 commit into from
Jun 25, 2019

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Jun 25, 2019

Fixes #1632

@Rob--W Rob--W requested a review from rpl June 25, 2019 10:51
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling dac152f on Rob--W:normalize-default_locale into 38a7b05 on mozilla:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling dac152f on Rob--W:normalize-default_locale into 38a7b05 on mozilla:master.

@rpl rpl merged commit 805b617 into mozilla:master Jun 25, 2019
@rpl rpl added this to In progress in 3.1.0 via automation Jul 1, 2019
@rpl rpl moved this from In progress to Done in 3.1.0 Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpl rpl rpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
3.1.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

_locales folder names should have underscore, not dash.
3 participants
@Rob--W @coveralls @rpl