Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to lodash required according to 'npm audit' #1659

Closed
moribellamy opened this issue Jul 16, 2019 · 2 comments · Fixed by #1663
Closed

upgrade to lodash required according to 'npm audit' #1659

moribellamy opened this issue Jul 16, 2019 · 2 comments · Fixed by #1663

Comments

@moribellamy
Copy link

https://www.npmjs.com/advisories/1065

currently at head we are pinned to 4.17.11, https://github.com/mozilla/web-ext/blob/master/package-lock.json#L31

@ghost
Copy link

ghost commented Jul 16, 2019

I think this requires an update to fx-runner.

└─┬ web-ext@3.1.0
  └─┬ fx-runner@1.0.10
    └── lodash@4.17.11 

Why are all these projects using exact versions of their dependencies? Wouldn't it be better to use "~4.17.11" or "^4.17.11"?

@raulrpearson
Copy link

I added an issue to the fx-runner repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants