Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require an ID when signing an extension #178

Closed
3 tasks done
kumar303 opened this issue Apr 7, 2016 · 8 comments
Closed
3 tasks done

Do not require an ID when signing an extension #178

kumar303 opened this issue Apr 7, 2016 · 8 comments
Assignees

Comments

@kumar303
Copy link
Contributor

kumar303 commented Apr 7, 2016

Once mozilla/addons#2648 lands on AMO, web-ext can be adjusted not to post an ID to the signing service.

Supports mozilla/addons#61

  • Update sign-addon for no-ID support
  • Update web-ext for no-ID support
  • Release sign-addon and bump the web-ext dependency
@kumar303
Copy link
Contributor Author

kumar303 commented May 4, 2016

@kumar303
Copy link
Contributor Author

@kumar303
Copy link
Contributor Author

just hit an API error

This was bogus. I had the API endpoint wrong.

@andymckay
Copy link
Contributor

We shouldn't be generating a 500 from user data though, so there might be a fix we need there to return a 400 or something.

@kumar303
Copy link
Contributor Author

kumar303 commented Jul 1, 2016

I'm pretty sure the 500 was from dirty dev data (multiple objects returned). I don't really think it's worth chasing down TBH. It doesn't happen when I use the right endpoint :)

@kumar303
Copy link
Contributor Author

kumar303 commented Jul 1, 2016

This will introduce a new option, web-ext sign --id ..., that needs documenting

@kumar303 kumar303 self-assigned this Jul 7, 2016
@kumar303
Copy link
Contributor Author

kumar303 commented Jul 7, 2016

sign-addon bumped here 5ea210d

@kumar303 kumar303 closed this as completed Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants