fix: Validate required parameters after reading config files. #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob--W
force-pushed
the
required-params-from-config
branch
from
ae11b8a
to
7aa95df
Compare
Rob--W
changed the title
rpl
requested changes
Jun 15, 2020
There was a problem hiding this comment.
@Rob--W thanks a lot for taking a look into this. I'm not super-thrilled about monkeypatching the yargs internals as a long-term solution but as a short-term workaround it can be fine (especially given the new tests added to catch regressions around that workaround).
There are a few nits that I would like to be handled on the test side (on the workaround implementation side I'm not requiring any actual changes, but it would be great if we could file a new issue to reference in the nearby inline comment, so that we may get back to this and see if we can think of a long-term solution that wouldn't need to monkeypatch yargs).
Rob--W
force-pushed
the
required-params-from-config
branch
from
7aa95df
to
0628b8e
Compare
rpl
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1327.