Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefoxdeveloperedition alias resolves surprisingly on macOS #1960

Closed
watters opened this issue Jul 14, 2020 · 1 comment
Closed

firefoxdeveloperedition alias resolves surprisingly on macOS #1960

watters opened this issue Jul 14, 2020 · 1 comment
Projects

Comments

@watters
Copy link

watters commented Jul 14, 2020

Is this a feature request or a bug?

A bug.

What is the current behavior?

Using the firefoxdeveloperedition alias for the -f option results in an attempt to launch a binary within /Applications/FirefoxDeveloperEdition.app rather than /Applications/Firefox Developer Edition.app, which fails (error below).

It looks like web-ext delegates alias resolution to node-fx-runner. I have filed a corresponding issue against node-fx-runner, but thought it was worth noting here as well because the alias is explicitly documented by web-ext.

As noted in the node-fx-runner issue, there are a couple of ways it attempts to resolve this alias, and they all appear to fail. I've worked around it, but it may be worth fixing OR at least removing from the documented set of options. I'm happy to do the work in web-ext or node-fx-runner.

Reproduction

Install Firefox Developer Edition from the official download location on macOS.

Command:

web-ext -f firefoxdeveloperedition run

Output:

Running web extension from /Users/watters/Dropbox/code/birdcage/dist
Error: spawn /Applications/FirefoxDeveloperEdition.app/Contents/MacOS/firefox-bin ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:267:19)
    at onErrorNT (internal/child_process.js:469:16)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)

What is the expected or desired behavior?

The expected behavior is that Firefox Developer Edition would be launched.

Version information (for bug reports)

  • Firefox Developer Edition 79.0b7 (64-bit):
  • macOS Catalina Version 10.15.5:
  • Paste the output of these commands:
node --version && npm --version && web-ext --version
v12.17.0
6.14.5
4.3.0
@Rob--W
Copy link
Member

Rob--W commented Jul 14, 2020

It would be nice to fix this with the next minor release, but if we don't have a minor release the major version would be good too.

@Rob--W Rob--W closed this as completed in e3f4d7f Jul 17, 2020
@rpl rpl moved this from Backlog to Done in 5.0.0 Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.0.0
Done
Development

No branches or pull requests

2 participants