Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building an XPI with only localizations makes an ugly file name #198

Closed
kumar303 opened this issue Apr 19, 2016 · 2 comments
Closed

Building an XPI with only localizations makes an ugly file name #198

kumar303 opened this issue Apr 19, 2016 · 2 comments
Labels
type: bug

Comments

@kumar303
Copy link
Contributor

Try running web-ext build in https://github.com/mdn/webextensions-examples/tree/master/notify-link-clicks-i18n

You get _msg_extensionname_-1.0.xpi which is ugly.
@kumar303 kumar303 changed the title Building an XPI with only localizations makes an ugly name Building an XPI with only localizations makes an ugly file name Apr 19, 2016
@kumar303 kumar303 mentioned this issue Apr 19, 2016
Closed
@kumar303
Copy link
Contributor Author

kumar303 commented Sep 13, 2016 •
edited

The fix is to adjust the build command to generate a locale aware filename. I think it would be reasonable to generate the filename using the default locale of the manifest when the extension is localized.

@shubheksha shubheksha mentioned this issue Sep 14, 2016
Merged
@Standard8 Standard8 mentioned this issue Sep 19, 2016
Open
@kumar303
Copy link
Contributor Author

fixed in #487 🌞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kumar303