Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need to click OK when connecting to the remote debugger #224

Closed
kumar303 opened this issue Apr 28, 2016 · 4 comments
Closed

Remove the need to click OK when connecting to the remote debugger #224

kumar303 opened this issue Apr 28, 2016 · 4 comments

Comments

@kumar303
Copy link
Contributor

Since web-ext is a development tool, it only adds friction to the process when you have to click OK in Firefox to allow the remote debugger connection. @rpl has an idea for using an add-on to disable this prompt :)

@rpl
Copy link
Member

rpl commented Apr 28, 2016

@kumar303 I took a rapid look and the good news is that now it is much more simple than in the past:
we can just use an existent preference, isn't it great? :-)

diff --git a/src/firefox/preferences.js b/src/firefox/preferences.js
index adc8106..ec08e15 100644
--- a/src/firefox/preferences.js
+++ b/src/firefox/preferences.js
@@ -75,6 +75,7 @@ prefs.firefox = {
   'startup.homepage_welcome_url.additional' : '',
   'devtools.errorconsole.enabled' : true,
   'devtools.chrome.enabled' : true,
+  'devtools.debugger.prompt-connection' : false,

References:

NOTE: this will be even more important if we want to run integration tests around the "run auto-reload" feature on a build machine.

@andymckay-limited-access

We looked at this the good first bug triage and we felt it probably wasn't a good first bug.

@kumar303
Copy link
Contributor Author

@kumar303
Copy link
Contributor Author

kumar303 commented May 2, 2016

I'm adding this as part of the patch to #222

@kumar303 kumar303 closed this as completed May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants