feat: enable MV3 by default in web-ext lint command
#2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdurand
force-pushed
the
mv3-default
branch
from
c52f912
to
7874627
Compare
willdurand
force-pushed
the
mv3-default
branch
from
7874627
to
f0c4dba
Compare
willdurand
changed the title
wwb-ext lint commandewb-ext lint command
willdurand
changed the title
ewb-ext lint commandweb-ext lint command
Codecov ReportBase: 99.58% // Head: 99.52% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2557 +/- ##
==========================================
- Coverage 99.58% 99.52% -0.06%
==========================================
Files 32 32
Lines 1697 1697
==========================================
- Hits 1690 1689 -1
- Misses 7 8 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rpl
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
@willdurand lgtm thanks, let's ignore codecov, the only line we are not covering is the newly added warning and that isn't that big of a deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2549
I'll update
web-ext runin a different patch.