Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect option configuration from breaking handlers #65

Open
kumar303 opened this issue Feb 23, 2016 · 1 comment
Open

Protect option configuration from breaking handlers #65

kumar303 opened this issue Feb 23, 2016 · 1 comment

Comments

@kumar303
Copy link
Contributor

In #39 I protected command handlers from accessing undeclared program options. However, it is still possible to add an option to the program and forget to declare it (in ProgramOptions). This could result in handler unit tests that silently fail because they are testing with stale options. Let's see if we can solve it without resorting to a slow integration test. Perhaps it can be solved with static analysis.

@kumar303
Copy link
Contributor Author

kumar303 commented Mar 1, 2018

Adding strong typing may solve this. See #1144

@kumar303 kumar303 added this to To do in Add-ons Q3 2018: Web-ext Maintenance via automation Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant