-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
globalThis.chrome?.runtime?.id causes Uncaught SyntaxError: Unexpected token . #420
Comments
Is it feasible to use an older polyfill version? E.g. 0.9.0 - https://github.com/mozilla/webextension-polyfill/releases/tag/0.9.0 ? If not, revert this change to get it to work again: c12424c |
Since this is a breaking change, it would seem that c12424c should have triggered a major version bump. I develop extensions that are also used by users of Chrome v49 on Windows XP and Firefox v56/Waterfox. I had to spend a few minutes figuring out why the extension was not working after a seemingly safe upgrade of |
0.x.0 can contain breaking changes: https://semver.org/#spec-item-4 That's why npm does not automatically update them: https://github.com/npm/node-semver#caret-ranges-123-025-004
|
Good to know, thanks. |
There still are substantial amount of users with Chromebooks that use old versions of Chrome (v76, v77 etc.). Optional chaining supported from v80.
globalThis.chrome?.runtime?.id
causesUncaught SyntaxError: Unexpected token .
This check was changed in version 0.10.0. Can we fix it to maintain compatability?
https://github.com/mozilla/webextension-polyfill/blob/0.10.0/src/browser-polyfill.js#L9
The text was updated successfully, but these errors were encountered: