Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Brick - Image Definition #22

Closed
thisandagain opened this issue Jul 30, 2014 · 3 comments
Closed

Brick - Image Definition #22

thisandagain opened this issue Jul 30, 2014 · 3 comments
Milestone

Comments

@thisandagain
Copy link
Contributor

No description provided.

@thisandagain thisandagain added this to the Design Refinements milestone Jul 30, 2014
@mhanratty
Copy link

Here is a first stab at the image brick from sketches for #9

jaipurstories-1
jaipurstories-2

Notes/Questions
• For images, are we going to have a default size that we are scaling images down for when they appear in an app? What if the image is a funky size? Can we allow user to crop/resize/move image around?
• Need to figure out auth flow for Facebook for first phases (before we have uploader up and running).
• Alternatively, we could show all options (Facebook, Instagram, Camera roll) on brick editing screen (rather than pushing this choice to modal)

@thisandagain
Copy link
Contributor Author

I'd say the answers to these questions could be split into MUP and ideal. First, for MUP:

  • Cropping / Aspect Ratio Control: Default size to the width of the screen (320px) and allow aspect ratio of the input image to determine height.

Ideal:

  • Most certainly would be great to have a crop flow for images selected through the gallery. Both iOS and Android (>= KitKat) do this really well as part of the gallery control. Might be worth checking in with the UX team for media applications on Firefox OS to see what they have planned.
  • For Facebook OAuth flow do we have any existing marketplace apps that are doing this? I'd like to get a sense of benchmarks here.

@mhanratty
Copy link

Hello World version of image editing

https://redpen.io/oec6c11df8665c9622

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants