Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Email should be used to reset password #2320

Closed
kumarrishav opened this issue Jun 25, 2015 · 12 comments
Closed

Email should be used to reset password #2320

kumarrishav opened this issue Jun 25, 2015 · 12 comments

Comments

@kumarrishav
Copy link

Currently app ask for username (if your email is already registered), but user hardly remember its username (as different application has different validation rules). So, instead we should use email to reset password as everyone remember it's email id

@cadecairos
Copy link
Contributor

shouldn't this really be in https://github.com/mozilla/id.webmaker.org

@thisandagain
Copy link
Contributor

We need to modify the UX as well so I'd like to keep this opened.

@xmatthewx
Copy link
Contributor

related: mozilla/id.webmaker.org#317

@anupkumarmishra
Copy link

when I organize webmaker events people ask me questions related to their account. When they forget their account details ,the only way to recover is through username . I guess we should change our system like that as most of the websites/applications provide the same mechanism.

@xmatthewx
Copy link
Contributor

@flukeout - Can you take a look at our existing signup, login, and account recovery and propose a few improvements? mozilla/id.webmaker.org#317 (comment)

@xmatthewx
Copy link
Contributor

Server supports recovery by email. Just need to update UI and frontend to allow for use of email. mozilla/id.webmaker.org#317 (comment)

Questions? ping @cadecairos

@xmatthewx xmatthewx assigned gvn and alicoding and unassigned gvn Jul 6, 2015
@ryanwarsaw
Copy link
Contributor

This should definitely be made a priority, if a user doesn't remember their username then they'll think they're forced to create a new account (I personally encountered this issue).

@xmatthewx
Copy link
Contributor

@ryanw-se and @kumarrishav - this update has landed. Please test it, break it, and let us know if you see any weird or unfriendly error messages.

@kumarrishav
Copy link
Author

Hey @xmatthewx , i tested this and have some feedback on this.

  1. While signing in , it should be "Username or Email" written out there instead of only Username as now both email n username can be used for signing in. Thanks for this)
  2. Reset link should be different everytime or have some expiration time. While testing i found that everytime it is sending same link, it means anyone can reset if they found that link. I tested the reset link in other android app, it's different everytime or have some expiration time like 6hrs or something.
  3. Instead of navigating to browser, can't we reset from the app only, so that it will email the reset link and then reset it from browser.

@cadecairos
Copy link
Contributor

Hey @kumarrishav

  1. While signing in , it should be "Username or Email" written out there instead of only Username as now both email n username can be used for signing in. Thanks for this)

The placeholder text should be 'username and email' already:
screenshot_2015-07-10_07-59-07

  1. Reset link should be different everytime or have some expiration time.

Reset links contain a unique code that is only valid once, and for a 24 hour period after it's created. (https://github.com/mozilla/login.webmaker.org/blob/1ddca67573fdc36439f470c971da4c474e6f1a89/app/db/models/index.js#L424-L451)

@xmatthewx
Copy link
Contributor

Thanks @kumarrishav

@kumarrishav
Copy link
Author

@cadecairos i was talking about signing in time not reset password.
http://picpaste.com/Screenshot_2015-07-10-19-07-40-bO6aISE5.png

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants