This repository has been archived by the owner on Jul 16, 2018. It is now read-only.
891546 build teaching kit thimble #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,52 @@ | |||
| # Copy this file to .env or just set these environment variables | |||
There was a problem hiding this comment.
Ignore this file, added to repo so I can deploy site on Heroku.
There was a problem hiding this comment.
Remove for when we land this please
There was a problem hiding this comment.
Also, we should bring this up in our review/deployment strategy
There was a problem hiding this comment.
Bring up wut, having a fallback solution for non-existent .env files so we can deploy to Heroku? Agreed!
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>Teaching Kit Template</title> | ||
| <link href='http://fonts.googleapis.com/css?family=Open+Sans:300,400,600' rel='stylesheet' type='text/css'> |
There was a problem hiding this comment.
Also, is there an https resource available? If not, can we use our own hosted version?
There was a problem hiding this comment.
There is an HTTPS version but you need to explicitly request it rather than using a protocol-less URL.
added 20 commits
July 26, 2013 11:03
|
Old; closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE, THESE CHANGES WILL LIVE IN A THIMBLE PROJECT, NOT WM.ORG