Fix deadlock when managing tabs with library panel open (#2891)

MozillaReality · Feb 27, 2020 · 13ca6fe · 13ca6fe
1 parent 33a3d6b
commit 13ca6fe
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java
@@ -1585,8 +1585,14 @@ public void onFirstContentfulPaint(@NonNull GeckoSession session) {
             mUIThreadExecutor.execute(mFirstDrawCallback);
             mFirstDrawCallback = null;
             mAfterFirstPaint = true;
-            mSetViewQueuedCalls.forEach(Runnable::run);
-            mSetViewQueuedCalls.clear();
+            // view queue calls need to be delayed to avoid a deadlock
+            // caused by GeckoSession.syncResumeResizeCompositor()
+            // See: https://github.com/MozillaReality/FirefoxReality/issues/2889
+            mUIThreadExecutor.execute(() -> {
+                mSetViewQueuedCalls.forEach(Runnable::run);
+                mSetViewQueuedCalls.clear();
+            });
+
         }
     }