Always add the new window to the center. Update tray when windows are…

… moved. (#1689)
MozillaReality · Aug 28, 2019 · 6d9dd2a · 6d9dd2a
1 parent 85ab9b8
commit 6d9dd2a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/app/src/common/shared/org/mozilla/vrbrowser/VRBrowserActivity.java b/app/src/common/shared/org/mozilla/vrbrowser/VRBrowserActivity.java
@@ -265,6 +265,11 @@ public void onFocusedWindowChanged(@NonNull WindowWidget aFocusedWindow, @Nullab
             public void onWindowBorderChanged(@NonNull WindowWidget aChangeWindow) {
                 mKeyboard.proxifyLayerIfNeeded(mWindows.getCurrentWindows());
             }
+
+            @Override
+            public void onWindowsMoved() {
+                updateWidget(mTray);
+            }
         });
 
         // Create Browser navigation widget

diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/Windows.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/Windows.java
@@ -88,6 +88,7 @@ public enum WindowPlacement{
     public interface Delegate {
         void onFocusedWindowChanged(@NonNull WindowWidget aFocusedWindow, @Nullable WindowWidget aPrevFocusedWindow);
         void onWindowBorderChanged(@NonNull WindowWidget aChangeWindow);
+        void onWindowsMoved();
     }
 
     public Windows(Context aContext) {
@@ -192,14 +193,16 @@ public WindowWidget addWindow() {
             placeWindow(frontWindow, WindowPlacement.RIGHT);
         } else if (leftWindow != null && focusedWindow == frontWindow) {
             // Opening a new window from front window
-            placeWindow(newWindow, WindowPlacement.RIGHT);
+            placeWindow(newWindow, WindowPlacement.FRONT);
+            placeWindow(frontWindow, WindowPlacement.RIGHT);
         } else if (rightWindow != null && focusedWindow == rightWindow) {
             // Opening a new window from right window
             placeWindow(newWindow, WindowPlacement.FRONT);
             placeWindow(frontWindow, WindowPlacement.LEFT);
         } else if (rightWindow != null && focusedWindow == frontWindow) {
             // Opening a new window from right window
-            placeWindow(newWindow, WindowPlacement.LEFT);
+            placeWindow(newWindow, WindowPlacement.FRONT);
+            placeWindow(frontWindow, WindowPlacement.LEFT);
         }
 
         updateMaxWindowScales();
@@ -292,6 +295,9 @@ public void moveWindowRight(@NonNull WindowWidget aWindow) {
             placeWindow(frontWindow, WindowPlacement.RIGHT);
         }
         updateViews();
+        if (mDelegate != null) {
+            mDelegate.onWindowsMoved();
+        }
     }
 
     public void moveWindowLeft(@NonNull WindowWidget aWindow) {
@@ -311,6 +317,9 @@ public void moveWindowLeft(@NonNull WindowWidget aWindow) {
             placeWindow(frontWindow, WindowPlacement.LEFT);
         }
         updateViews();
+        if (mDelegate != null) {
+            mDelegate.onWindowsMoved();
+        }
     }
 
     public void focusWindow(@NonNull WindowWidget aWindow) {