Fixes #2568 Fix issue with shift and multi tapping (#2636)

* Fix issue with shift and multi tapping * Improved multitap timeout and keyboard update
MozillaReality · Jan 29, 2020 · 854287c · 854287c
1 parent d3d21e6
commit 854287c
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/views/CustomKeyboardView.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/views/CustomKeyboardView.java
@@ -256,7 +256,7 @@ public interface OnKeyboardActionListener {
     private int mTapCount;
     private long mLastTapTime;
     private boolean mInMultiTap;
-    private static final int MULTITAP_INTERVAL = 800; // milliseconds
+    private static final int MULTITAP_INTERVAL = 250; // milliseconds
     private StringBuilder mPreviewLabel = new StringBuilder(1);
 
     /** Whether the keyboard bitmap needs to be redrawn before it's blitted. **/
@@ -547,11 +547,10 @@ public Keyboard getKeyboard() {
      */
     public boolean setShifted(boolean shifted) {
         if (mKeyboard != null) {
-            if (mKeyboard.setShifted(shifted)) {
-                // The whole keyboard probably needs to be redrawn
-                invalidateAllKeys();
-                return true;
-            }
+            mKeyboard.setShifted(shifted);
+            // The whole keyboard probably needs to be redrawn
+            invalidateAllKeys();
+            return true;
         }
         return false;
     }
@@ -1519,7 +1518,10 @@ private void checkMultiTap(long eventTime, int keyIndex) {
             }
 
         } else if (key.codes[0] == CustomKeyboard.KEYCODE_SHIFT) {
-            mInMultiTap = true;
+            if (eventTime < mLastTapTime + MULTITAP_INTERVAL
+                    && keyIndex == mLastSentIndex) {
+                mInMultiTap = true;
+            }
         }
 
         if (eventTime > mLastTapTime + MULTITAP_INTERVAL || keyIndex != mLastSentIndex) {