Work around Oculus ColorScale bug (#3259)

MozillaReality · Apr 27, 2020 · a7cbec3 · a7cbec3
1 parent 32305d7
commit a7cbec3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/app/src/main/cpp/vrb b/app/src/main/cpp/vrb
diff --git a/app/src/oculusvr/cpp/OculusVRLayers.h b/app/src/oculusvr/cpp/OculusVRLayers.h
@@ -77,9 +77,11 @@ class OculusLayerBase : public OculusLayer {
   virtual void
   Update(const ovrTracking2 &aTracking, ovrTextureSwapChain *aClearSwapChain) override {
     vrb::Color tintColor = layer->GetTintColor();
-    if (!IsComposited() && layer->GetClearColor().Alpha()) {
+    if (!IsComposited() && (layer->GetClearColor().Alpha() > 0.0f)) {
       tintColor = layer->GetClearColor();
+      tintColor.SetRGBA(convertColor(tintColor.Red()), convertColor(tintColor.Green()), convertColor(tintColor.Blue()), tintColor.Alpha());
     }
+
     ovrLayer.Header.ColorScale.x = tintColor.Red();
     ovrLayer.Header.ColorScale.y = tintColor.Green();
     ovrLayer.Header.ColorScale.z = tintColor.Blue();
@@ -158,7 +160,17 @@ class OculusLayerBase : public OculusLayer {
     return (IsComposited() || layer->GetClearColor().Alpha() == 0) ? swapChain : aClearSwapChain;
   }
 
+protected:
   virtual ~OculusLayerBase() {}
+
+  // Convert sRGB to linear RGB. Used to work around bug in Oculus compositor.
+  float convertColor(const float color) {
+    if (color > 0.04045f) {
+      return powf(color + 0.055f, 2.4f) / 1.055f;
+    } else {
+       return color / 12.92f;
+    }
+  }
 };