Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restored commented code on Tray Intersection check #96

Closed
keianhzo opened this issue Jul 6, 2018 · 1 comment
Closed

Restored commented code on Tray Intersection check #96

keianhzo opened this issue Jul 6, 2018 · 1 comment
Assignees
@keianhzo
Labels
bug This issue is a software or functional defect P0 Hotfix or blocker during release preparation
Projects
v1.0
Milestone
V1.0

Comments

@keianhzo
Copy link
Collaborator

keianhzo commented Jul 6, 2018

This check got commented while adding Tray support as it wasn't always returning. Probably related as how the collider normal is calculated. Research, fix and uncomment.

FirefoxReality/app/src/main/cpp/Tray.cpp

Lines 103 to 106 in ac6f015

// if (dotNormals > -kEpsilon) {
// // Not pointed at the plane
// return false;
// }

@keianhzo keianhzo self-assigned this Jul 6, 2018
@bluemarvin bluemarvin added the bug This issue is a software or functional defect label Jul 9, 2018
@nancyhang nancyhang added P0 Hotfix or blocker during release preparation v1.0 and removed v1.0 labels Jul 18, 2018
@nancyhang nancyhang added this to the V1.0 milestone Jul 18, 2018
@nancyhang nancyhang added this to To do in v1.0 Jul 18, 2018
@keianhzo keianhzo mentioned this issue Jul 19, 2018
Closed
@keianhzo
Copy link
Collaborator Author

No longer needed after the new Android UI based tray.

v1.0 automation moved this from To do to Done Jul 25, 2018
@larsbergstrom larsbergstrom modified the milestone: V1.0 Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keianhzo keianhzo

Labels
bug This issue is a software or functional defect P0 Hotfix or blocker during release preparation
Projects
No open projects
v1.0
  
Done
Milestone
V1.0
Development

No branches or pull requests
4 participants
@bluemarvin @larsbergstrom @keianhzo @nancyhang