Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixes #864: Added Contributing.md #1028

Merged
merged 2 commits into from Mar 21, 2019

Conversation

suhailsinghbains
Copy link
Collaborator

Fixes #864: Added Contributing.md

@cvan cvan self-requested a review March 18, 2019 23:20
@cvan cvan removed their assignment Mar 18, 2019
Copy link
Contributor

@cvan cvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 many thanks for opening this PR. this guide will be super useful for new contributors.

see my few minor comments, and I'll re-review. thank you, @suhailsinghbains!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
it, you can @-reply a reviewer asking for a review in the pull request or a
comment, or you can ask for a review in `#firefox` on `irc.mozilla.org`.

For specific git instructions, see [GitHub workflow 101](https://github.com/servo/servo/wiki/Github-workflow).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@suhailsinghbains suhailsinghbains changed the title Fixes #864: Added Contributing.md [WIP] Fixes #864: Added Contributing.md Mar 19, 2019
@ghost ghost added the in progress label Mar 19, 2019
Copy link
Contributor

@cvan cvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent work - thank you for addressing my minor nitpicks. much appreciated!

thank you for being a contributor to Firefox Reality 😄

@cvan cvan merged commit dc3efee into MozillaReality:master Mar 21, 2019
@ghost ghost removed the in progress label Mar 21, 2019
@cvan cvan added this to the v1.1.4 milestone Mar 21, 2019
@cvan cvan modified the milestones: v1.1.4, v1.1.3 Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a CONTRIBUTING.md for Contributing to Firefox Reality
2 participants