Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icons and logos with low-poly versions (fixes issue #1016) #1033

Merged
merged 4 commits into from Mar 21, 2019

Conversation

cvan
Copy link
Contributor

@cvan cvan commented Mar 19, 2019

for issue #1016


Before

Release

image

image

Developer Edition

image

image

After

Release

Pico G2

image

image

Oculus Go

image

image

Developer Edition

Pico G2

image

image

Oculus Go

image

image


Figma source files (Public, Read-only)

@cvan cvan added this to the v1.1.4 milestone Mar 19, 2019
@cvan cvan self-assigned this Mar 19, 2019
@ghost ghost added the in progress label Mar 19, 2019
@cvan
Copy link
Contributor Author

cvan commented Mar 19, 2019

Developer Edition

Oculus Go

image

Let me know if I should change the graphic to be grayscale when FxR is loading in the Developer Edition build. Thanks!

@philip-lamb
Copy link
Contributor

Other places I still see the old logo or variants:

app/src/main/res/drawable/sad_fox.png
app/src/main/res/drawable/ffgvr_background.png
app/src/main/res/drawable/ffgvr_foreground.png
app/src/main/res/mipmap-hdpi/ic_launcher.png
app/src/main/res/mipmap-hdpi/ic_launcher_foreground.png
app/src/main/res/mipmap-hdpi/ic_launcher_round.png
app/src/main/res/mipmap-mdpi/ic_launcher.png
app/src/main/res/mipmap-mdpi/ic_launcher_foreground.png
app/src/main/res/mipmap-mdpi/ic_launcher_round.png
app/src/main/res/mipmap-xhdpi/ic_launcher.png
app/src/main/res/mipmap-xhdpi/ic_launcher_foreground.png
app/src/main/res/mipmap-xhdpi/ic_launcher_round.png
app/src/main/res/mipmap-xxhdpi/ic_launcher.png
app/src/main/res/mipmap-xxhdpi/ic_launcher_foreground.png
app/src/main/res/mipmap-xxhdpi/ic_launcher_round.png
app/src/main/res/mipmap-xxxhdpi/ic_launcher.png
app/src/main/res/mipmap-xxxhdpi/ic_launcher_foreground.png
app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png
app/src/main/ic_launcher-web.png
app/src/wavevr/res/mipmap-mdpi/ic_launcher.png
app/src/wavevr/res/mipmap-hdpi/ic_launcher.png
app/src/wavevr/res/mipmap-xxxhdpi/ic_launcher.png
app/src/wavevr/res/mipmap-xxhdpi/ic_launcher.png
app/src/wavevr/res/mipmap-xhdpi/ic_launcher.png

Copy link
Contributor

@philip-lamb philip-lamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need launcher icons and a few others.

@cvan
Copy link
Contributor Author

cvan commented Mar 19, 2019

@philip-lamb good catches, will update. thanks!

@cvan
Copy link
Contributor Author

cvan commented Mar 19, 2019

@philip-lamb: thanks again!

I'm updating the icons here, and will update this PR shortly.

will keep this checklist below to keep track of them:

  • app/src/main/res/drawable/sad_fox.png (no changes needed, IMO)
  • app/src/main/res/drawable/ffgvr_background.png
  • app/src/main/res/drawable/ffgvr_foreground.png
  • app/src/main/res/mipmap-hdpi/ic_launcher.png
  • app/src/main/res/mipmap-hdpi/ic_launcher_foreground.png
  • app/src/main/res/mipmap-hdpi/ic_launcher_round.png
  • app/src/main/res/mipmap-mdpi/ic_launcher.png
  • app/src/main/res/mipmap-mdpi/ic_launcher_foreground.png
  • app/src/main/res/mipmap-mdpi/ic_launcher_round.png
  • app/src/main/res/mipmap-xhdpi/ic_launcher.png
  • app/src/main/res/mipmap-xhdpi/ic_launcher_foreground.png
  • app/src/main/res/mipmap-xhdpi/ic_launcher_round.png
  • app/src/main/res/mipmap-xxhdpi/ic_launcher.png
  • app/src/main/res/mipmap-xxhdpi/ic_launcher_foreground.png
  • app/src/main/res/mipmap-xxhdpi/ic_launcher_round.png
  • app/src/main/res/mipmap-xxxhdpi/ic_launcher.png
  • app/src/main/res/mipmap-xxxhdpi/ic_launcher_foreground.png
  • app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png
  • app/src/main/ic_launcher-web.png
  • app/src/wavevr/res/mipmap-mdpi/ic_launcher.png
  • app/src/wavevr/res/mipmap-hdpi/ic_launcher.png
  • app/src/wavevr/res/mipmap-xxxhdpi/ic_launcher.png
  • app/src/wavevr/res/mipmap-xxhdpi/ic_launcher.png
  • app/src/wavevr/res/mipmap-xhdpi/ic_launcher.png
  • app/src/wavevr/ic_launcher-web.png (new)

@MortimerGoro
Copy link
Contributor

@cvan FWIW I normally use https://github.com/laptrinhcomvn/app-icon-generator to generate all the Android icon sizes from a big logo image

@cvan cvan requested a review from philip-lamb March 21, 2019 03:02
@cvan
Copy link
Contributor Author

cvan commented Mar 21, 2019

@MortimerGoro: darn, I should've asked how they were generated. wasn't sure if they were manually or automatically generated. anyway, done now. I was able to do it well enough here, and I made some adjustments as needed so things looked normal.

feel free to review this as well, @philip-lamb too.

here's the final updated list.

@cvan cvan merged commit ff4f484 into master Mar 21, 2019
@ghost ghost removed the in progress label Mar 21, 2019
@cvan cvan deleted the fxr-icon-redesign branch March 21, 2019 05:27
@cvan cvan modified the milestones: v1.1.4, v1.1.3 Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants