Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git sha doesn't show up upon double-clicking the Version in Settings #1041

Closed
cvan opened this issue Mar 23, 2019 · 1 comment
Closed

Git sha doesn't show up upon double-clicking the Version in Settings #1041

cvan opened this issue Mar 23, 2019 · 1 comment
Assignees
@cvan
Labels
bug This issue is a software or functional defect regression
Milestone
v1.1.4

Comments

@cvan
Copy link
Contributor

cvan commented Mar 23, 2019

Steps to Reproduce

  1. Load the Settings.
  2. Double-click on the Version.
  3. Notice the git sha doesn't show up.

Current Behavior

The git sha used to show up when you double clicked on the Version line.

Something must've regressed in SettingsWidget.

Expected Behavior

The git sha used to shows up when you click on the Version line. We can remove the need for a double click and display it on a single click instead.
@cvan cvan added bug This issue is a software or functional defect regression labels Mar 23, 2019
@cvan cvan changed the title Double-clicking on the Version in Settings doesn't Git sha doesn't show up upon double-clicking the Version in Settings Mar 23, 2019
@philip-lamb philip-lamb added this to the v1.2 milestone Apr 1, 2019
@philip-lamb philip-lamb added the P2 Fix in the next development iteration label Apr 1, 2019
cvan added a commit that referenced this issue Apr 11, 2019
@cvan
fix Version toggle: show git sha on long-pressing Version string (fix…
a49e236 
…es issue #1041); improve click target
@cvan cvan mentioned this issue Apr 11, 2019
Merged
MortimerGoro pushed a commit that referenced this issue Apr 11, 2019
@cvan @MortimerGoro
fix Version toggle: show git sha on long-pressing Version string (fix…
158df24 
…es issue #1041); improve click target (#1073)
@cvan
Copy link
Contributor Author

cvan commented Apr 11, 2019

handled in PR #1073

@cvan cvan closed this as completed Apr 11, 2019
@philip-lamb philip-lamb removed the P2 Fix in the next development iteration label Apr 11, 2019
@cvan cvan self-assigned this Apr 11, 2019
@cvan cvan modified the milestones: v1.2, v1.1.4 Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvan cvan

Labels
bug This issue is a software or functional defect regression
Projects
None yet
Milestone
v1.1.4
Development

No branches or pull requests
2 participants
@cvan @philip-lamb